Skip to content
  • Joe Woodward's avatar
    Do not parse git-notes commits during git access checks · 65f0c6e5
    Joe Woodward authored
    git-notes are stored in refs/notes/commits as commit objects. This means
    when we push the notes to gitlab the BranchCheck, TagCheck, and
    DiffCheck classes are parsing those commits. Users don't control these
    commits, git handles those internally, the messages are produced by git
    e.g.
    
    `Notes added by 'git notes add'`
    `Notes removed by 'git notes remove'`
    
    Before this change, git-notes commits were being flagged by
    push_rule.commit_regex as not following the regex.
    
    We currently don't have any rules for checking notes so we can skip
    these for the time-being.
    
    Fixes #207807
    
    Changelog: fixed
    65f0c6e5