Skip to content
Snippets Groups Projects
Select Git revision
  • dennis/clarify-clickhouse-stages
  • sk/519723-cleanup
  • rd-rename-spp-svg
  • secret-rule-suggestions
  • trizzi-master-patch-e3ff
  • igloude-editor-a11y-followup
  • master default protected
  • 487363-move-maven-vreg-api-classes-to-EE
  • rails-next protected
  • ruby-next protected
  • jmd/auto-explain-on-mr
  • backfill-secret-push-protection-enabled
  • trizzi-master-patch-3bf1
  • 511982-policies-move-user-select-to-shared
  • 520302-test-mrdc-message-access
  • user-security-pin-ui
  • 466561-breakout-mailer
  • 506451-policies-clean-up-ff-new_yaml_format-clean-up
  • 494317-fetch-policies-when-open-section
  • jmc-dq-settings-sync
  • v17.9.0-ee protected
  • v17.9.0-rc42-ee protected
  • v17.6.5-ee protected
  • v17.7.4-ee protected
  • v17.8.2-ee protected
  • v17.6.4-ee protected
  • v17.7.3-ee protected
  • v17.8.1-ee protected
  • v17.8.0-ee protected
  • v17.7.2-ee protected
  • v17.8.0-rc42-ee protected
  • v17.5.5-ee protected
  • v17.6.3-ee protected
  • v17.7.1-ee protected
  • v17.7.0-ee protected
  • v17.7.0-rc42-ee protected
  • v17.4.6-ee protected
  • v17.5.4-ee protected
  • v17.6.2-ee protected
  • v17.6.2-rc31-ee protected
40 results

toggle_resolve.rb

  • Malcolm Locke's avatar
    3a9d20e7
    Remove duplicate implementations of find_object() · 3a9d20e7
    Malcolm Locke authored
    We have just over 50 duplicate implementations of the method
    `find_object` in our graphql mutation classes.
    
    This change replaces these by updateing the existing default
    implementation, which raises a `NotImplementedError`, with the
    behaviour from the duplicate implementations which is by
    definition the default implementation.
    
    This change also removes some superclasses and one module whose only
    function was to implement `find_object` in the same way.
    
    In some cases the method signatures were `find_object(id)` rather than
    `find_object(id:)` - note the non keyword argument.  In those cases the
    caller (`find_object` is called with argument pass through from
    `authorized_find!`) has been updated.
    3a9d20e7
    History
    Remove duplicate implementations of find_object()
    Malcolm Locke authored
    We have just over 50 duplicate implementations of the method
    `find_object` in our graphql mutation classes.
    
    This change replaces these by updateing the existing default
    implementation, which raises a `NotImplementedError`, with the
    behaviour from the duplicate implementations which is by
    definition the default implementation.
    
    This change also removes some superclasses and one module whose only
    function was to implement `find_object` in the same way.
    
    In some cases the method signatures were `find_object(id)` rather than
    `find_object(id:)` - note the non keyword argument.  In those cases the
    caller (`find_object` is called with argument pass through from
    `authorized_find!`) has been updated.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.