Skip to content

Allow unknown fields in jsonpb gitaly-proto messages

Jacob Vosmaer requested to merge jsonpb-unknown-fields into master

Follow-up to !364 (merged)

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/57589

For reasons unknown, github.com/golang/protobuf/jsonpb behaves differently from how we normally use protobuf: it is normally not an error to have an unknown field in a protobuf message because the other side will just ignore it. In jsonpb, it is an error to have unknown fields. I don't think this is the behavior that we want. This change adds a custom jsonpb unmarshaler that allows unknown fields.

Merge request reports