Skip to content

Fix handleError for example

Paul Slaughter requested to merge ps-fix-example-error-handling into main
  • Previously the error wasn't being logged and we would just randomly reload
  • Now we use a console.error and alert
  • We don't reload so that the developer can easily view the error.

Screenshots

Patch to throw an error
diff --git a/packages/vscode-bootstrap/src/start.ts b/packages/vscode-bootstrap/src/start.ts
index d6f2e8b..2f6a83f 100644
--- a/packages/vscode-bootstrap/src/start.ts
+++ b/packages/vscode-bootstrap/src/start.ts
@@ -52,6 +52,7 @@ const startWorkbench = (
   let skipCloseHandling = false;
 
   try {
+    throw new Error('BLOW UP!');
     const { dispose } = create(document.body, {
       ...BASE_OPTIONS,
       ...options,
Screenshot

Screen_Shot_2022-12-11_at_5.17.55_PM

Edited by Paul Slaughter

Merge request reports