fix: Detailed error message after failed commit
Issue: [Regression] Generic error message after failed... (#329 - closed)
Description
- After these changes we inadvertently broke the error message presentation because we expected the message to be a JSON object of status, body
Screenshots
Before | After |
---|---|
How to test?
- Start the Web IDE Example App locally
yarn start:example
. - Connect the Web IDE Example App either to local GDK or
gitlab.com
with Auth set. - Make a change and go to the Source Control tab and click the dropdown next to commit and select Commit to new branch
- Enter the name of an existing branch (not the one you're currently on) which should cause the commit to fail.
- You should see a helpful error message like
You're not allowed to push to this branch
, not a generic one.
Also, checkout this part of the Web IDE where we handle all of these error cases (can give you an idea of whether or not this is working and how to force a failure on commit):
Edited by Paul Slaughter