fix: MR compare with empty file and opening from commit ID
- This is because we changed the kind of error we throw
- The 404AsEmpty decorator looks for content in this error to determine if its a 404 or not
Screenshots
When opening an MR with new file:
| Before | After |
|---|---|
 |
 |
When opening Web IDE from commit ID
| Before | After |
|---|---|
 |
 |
How to test?
When opening an MR with new file:
- In the
package.jsonof localgdk, point the@gitlab/web-idepackage to the artifact ofcreate-development-packageof this MR pipeline (see patch below). - Run
yarn install - Open an MR that introduces new files
- Open the Web IDE from the MR under Code dropdown
- There should be no errors
✅
When opening Web IDE from commit ID:
- In the
package.jsonof localgdk, point the@gitlab/web-idepackage to the artifact ofcreate-development-packageof this MR pipeline (see patch below). - Run
yarn install - Open a project repository tree at a specific commit (not a branch)
- Open the Web IDE under Edit dropdown
- There should be no errors
✅
Patch for running this MR's Web IDE in local GDK
Based on recent pipeline https://gitlab.com/gitlab-org/gitlab-web-ide/-/jobs/6121405284
diff --git a/package.json b/package.json
index c903c25d9fb1..63d0bf0b67ae 100644
--- a/package.json
+++ b/package.json
@@ -63,7 +63,7 @@
"@gitlab/svgs": "3.80.0",
"@gitlab/ui": "^73.1.1",
"@gitlab/visual-review-tools": "1.7.3",
- "@gitlab/web-ide": "^0.0.1-dev-20240201215504",
+ "@gitlab/web-ide": "https://gitlab.com/gitlab-org/gitlab-web-ide/-/jobs/6121405284/artifacts/raw/tmp/packages/gitlab-web-ide-0.0.1-dev-20240207221315.tgz",
"@mattiasbuelens/web-streams-adapter": "^0.1.0",
"@rails/actioncable": "7.0.8",
"@rails/ujs": "7.0.8",
Edited by Paul Slaughter