Skip to content

fix: Move handleMessages to after load

Paul Slaughter requested to merge ps-fix-message-handling into main
  • Before, it seems that handleMessages was being called before load causing some very noticeable bugs.
  • This fixes the Web IDE remote development dialog
  • This fixes the Web IDE shouldPrevent handling

What caused this regression?

How to test

  1. Open the example app and enter a GitLab Token so you can make changes.
  2. Make changes on a file and wait for the indicator in the Source Control tab to show.
  3. Try to exit the browser tab (also by pressing COMMAND+W). The Web IDE should warn you about losing changes.

Screenshot

Before After
before_bug Screenshot_2023-05-08_at_1.33.40_AM
Firefox Safari Chrome
Screenshot_2023-05-08_at_10.18.19_AM Screenshot_2023-05-08_at_10.19.20_AM Screenshot_2023-05-08_at_10.21.00_AM
Edited by Paul Slaughter

Merge request reports

Loading