[WebIDE] Workspace settings does not take into effect immediately after the Web IDE loads
MR: Pending
Description
As noted in this discussion, when loading the Web IDE with workspace settings configured it does not take into effect immediately. You will need to open and save the file to trigger updating the Web IDE's state. This does not happen with user settings.
Steps to reproduce:
- Open project on the Web IDE and add workspace settings (ex: setting default theme). You can do this via the command palette (by searching for
Workspace Settings (JSON)
or manually creating a.vscode/setting.json
file in the root of the directory. - Save the file and notice theme change.
- Stage change and commit
- Reload the Web IDE. Observe that the theme is not applied.
- Repeat the above, this time in a new branch. Observe that the theme is not applied when switching to the branch.
Acceptance Criteria
-
When the Web IDE is initialized or when switching branches, existing workspace settings should be applied immediately.
Implementation Plan
-
Revert changes introduced in feat: don't wait for initializeWithProgress on ... (!311 - merged), which caused this regression. More context discussed here. -
Reload window when the Web IDE context is updated, so that Workspace settings take into effect on ref/branch change.
Edited by Cindy Halim