Skip to content

Fix SSH URL parsing for URLs with custom ports

Johannes May requested to merge johannesmay/gitlab-vscode-extension:fix/ssh_url_parsing into main

As pointed out by @yajoman in #611 (closed) (See this comment: #611 (comment 1154175809)), the fix for #611 (closed) was not sufficient and in fact wrong for URLs without URL schemes. Furthermore, custom ports in SSH URLs with a URL scheme are not properly handled at all.

This MR extends the support to three kinds of URLs:

  • [git@example.com:2222]:fatihacet/gitlab-vscode-extension.git, which is interpreted as host example.com, port 2222 and the path fatihacet/gitlab-vscode-extension.git
  • ssh://git@example.com:2222/fatihacet/gitlab-vscode-extension.git, which is interpreted as host example.com, port 2222 and the path fatihacet/gitlab-vscode-extension.git
  • git@example.com:2222/fatihacet/gitlab-vscode-extension.git, which is interpreted as host example.com, default port (22) and the path 2222/fatihacet/gitlab-vscode-extension.git

Relates to #611 (closed), #644

Edited by Johannes May

Merge request reports