Skip to content

fix: extension ignores expired token and fails in the wrong place

Tomas Vik requested to merge 487-handling-expired-token into main

This MR fixes an issue where the extension couldn't detect an expired token and it instead threw a generic request failed error. This made these trivial errors hard to debug and users often created an issue in our issue tracker.

This MR did the following changes:

  1. move the token checking logic from remote FS code to GitLabNewService where all API calls can use it
  2. move the fetchJson method in the GitLabNewService for easier use
  3. migrate direct crossFetch (our fetch library) calls to use the fetch function which does expired token handling

The MR is split into 7 commits for easier review.

Related to #487 (closed)

Edited by Tomas Vik

Merge request reports