fix: Don't show error on startup when user is offline

Lennard Sprongrequested to merge
gitlab-community/gitlab-org/gitlab-vscode-extension:X_Sheep/offline-accounts into main

Description

This changes the Account Validation logic that runs on extension startup to not show an error if the GitLab instance is unreachable. The extension will now only proactively show an error if the instance is reachable but the token is invalid. The old logic is still intact when calling the "GitLab: Validate Accounts" command from the command palette.

Related Issues

Resolves #1962 (closed)

How has this been tested?

  1. Authenticate with the extension
  2. Disable all networking on your device, e.g. enable Airplane mode
  3. Open a folder that has a connected GitLab project
  4. The error should not display.
  • If src/browser or src/common has been modified, please consider interoperability with the Web IDE. See Running the Extension in WebIDE.
  • Consider an end-to-end test for significant new features that aren't covered by integration tests.

Screenshots (if appropriate)

The error message in question

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes

Merge request reports