fix: Read showClosedMergeRequests setting

Lennard Sprongrequested to merge
gitlab-community/gitlab-org/gitlab-vscode-extension:X_Sheep/fix-closed-mr-setting into main

Description

After the refactor in !3062 (merged), there were two functions that did the same thing, i.e. select the most relevant pipeline from a list. One of these functions did not read the configuration setting that ignores closed MRs.

This MR removes one of the functions, and changes the other function to respect the configuration setting.

Related Issues

Resolves #2267 (closed)

How has this been tested?

  • If src/browser or src/common has been modified, please consider interoperability with the Web IDE. See Running the Extension in WebIDE.
  • Consider an end-to-end test for significant new features that aren't covered by integration tests.

Screenshots (if appropriate)

See !3059 (merged)

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes

Merge request reports