fix: remove Snowplow LS startup tracking in favour of OpenTelemetry
Description
Remove the Snowplow Language Server startup tracking now that OpenTelemetry (OTel) is in place and data is flowing to the GitLab observability dashboard (introduced in !3207 (merged)).
Changes:
- Remove Snowplow imports and
#trackStartupTelemetrymethod fromLanguageServerStartupMonitor - Extract histogram recording into a focused
#recordStartupMetricshelper (OTel spans and histogram remain unchanged) - Drop the now-unused
telemetryEnvironmentconstructor parameter fromLanguageServerStartupMonitor - Update all callers and tests accordingly
All metrics/attributes previously tracked via Snowplow are already covered by the OTel implementation:
ls.startupspan attributes:status,failed_phase,spawn_duration_ms,handshake_duration_ms,total_duration_ms,restart_attemptsls.startup.durationhistogram:status,failed_phase
Related Issues
Resolves #2290 (closed)
How has this been tested?
-
Reviewed that all OTel span attributes and histogram metrics cover the same data as the removed Snowplow payload
-
Updated unit tests to remove Snowplow mock and related assertions; all existing phase-transition and timeout tests remain intact
-
If
src/browserorsrc/commonhas been modified, please consider interoperability with the Web IDE. -
Consider an end-to-end test for significant new features that are not covered by integration tests.
Screenshots (if appropriate)
N/A
What CHANGELOG entry will this MR create?
-
fix:Bug fix - included in changelog -
feature:New feature - included in changelog -
BREAKING CHANGE:- should bump major version - None - other non-user-facing changes