fix: Ensure footer toggle enables/disables code suggestions
Description
This change simplifies how the code suggestions toggle feature works. Previously, the toggle had complex behavior where it would either enable suggestions globally or disable them temporarily for just the current session, depending on the current state.
Now it has been streamlined to always toggle the global setting directly - if suggestions are off, it turns them on globally, and if they're on, it turns them off globally. This makes the behavior more predictable and consistent, while also ensuring that other parts of the system (like the language server and diagnostics) are properly notified of the change. The code was also cleaned up by removing dependencies on state management components that are no longer needed, and the tests were updated to reflect this simpler behavior.
Related Issues
Resolves [VSCode] Code Suggestions not disabled from foo... (#2078 - closed)
How has this been tested?
- If
src/browserorsrc/commonhas been modified, please consider interoperability with the Web IDE. See Running the Extension in WebIDE. - Consider an end-to-end test for significant new features that aren't covered by integration tests.
Screenshots (if appropriate)
What CHANGELOG entry will this MR create?
-
fix:Bug fix fixes - a user-facing issue in production - included in changelog -
feature:New feature - a user-facing change which adds functionality - included in changelog -
BREAKING CHANGE:(fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog - None - other non-user-facing changes