refactor: Remove deprecated settings for status bar items

Lennard Sprongrequested to merge
gitlab-community/gitlab-org/gitlab-vscode-extension:X_Sheep/remove-status-bar-settings into main

Description

This is the followup to !649 (merged). The old settings were deprecated 3 years ago, and this MR removes them entirely.

In VS Code, a setting is hidden from users immediately on deprecation, unless they have altered this setting beforehand. So in practice this doesn't cause any change for any user who installed this extension less than 3 years ago, and for other users it's simple to hide the status bar items again (see screenshot).

Related Issues

See #588 (closed)

How has this been tested?

  • If src/browser or src/common has been modified, please consider interoperability with the Web IDE. See Running the Extension in WebIDE.
  • Consider an end-to-end test for significant new features that aren't covered by integration tests.

Screenshots (if appropriate)

statusbar_ids

The replacement, as introduced in !649 (merged).

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes

Merge request reports