Skip to content

feat: Re-authenticating does not ask for delete

Shekhar Patnaikrequested to merge
spatnaik/reauthenticating_does_not_ask_for_delete into main

Description

Today, when the user re-authenticates if the host exists, we ask the user to first delete the account. Most the time the user wants to override their current credentials when going through the process, so it doesn't make sense to ask them to go through the step of deleting the account.

Related Issues

Resolves #2154 (closed)

How has this been tested?

  • Login to GitLab.com using a PAT using the extension command (> GitLab: Authenticate)
  • Login to GitLab.com again using a PAT using the extension command
  • It should not show you a popup asking you to delete the account.
  • If src/browser or src/common has been modified, please consider interoperability with the Web IDE. See Running the Extension in WebIDE.
  • Consider an end-to-end test for significant new features that aren't covered by integration tests.

Screenshots (if appropriate)

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes
Edited by Shekhar Patnaik

Merge request reports