fix: support ee suffix in version check

Tristan Readrequested to merge
tr/support-ee-in-version-check into main

Description

Small fix to use coerce from semver on the Chat GitLab instance version check, to handle possible -ee suffixes that can be appended in certain cases.

Related Issues

Resolves [VS Code] SemVer version check is calculated wr... (#2105 - closed)

How has this been tested?

To reproduce this, a number of things have to be true:

  1. The instance has to have a suffix (e.g. Dedicated) and be version 17.5.0.
  2. The legacy chat UI has to be in use (either via a feature flag, or the language server being off - aka Web IDE).

Instead of testing it locally, I would encourage inspecting the code changes, as well as the JS repl reproduction of the issue here: https://playcode.io/2532013.

You could also remove the first commit and see that the tests fail.

  • If src/browser or src/common has been modified, please consider interoperability with the Web IDE. See Running the Extension in WebIDE.
  • Consider an end-to-end test for significant new features that aren't covered by integration tests.

Screenshots (if appropriate)

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes
Edited by Tristan Read

Merge request reports