Skip to content

Fix pipeline notification

Kasper Laursen requested to merge Clapfire/gitlab-vscode-extension:master into master

Using the newest version of vs code (1.29.1) and this extension (1.5.0), the pipeline notification button is no longer displayed correctly.
Tested on Windows 10 and Windows 10 Pro on two different machines.
It currently shows this:

image

It should show this:

image

Passing the message const into the showInformationMessage does not produce the correct behavior. This was changed in c083c676. I am not sure if it broke during that change, or after VS Code updated, since they changed the behavior of the showInformationMessage API in 1.29.1 (See Changelog)

Unfortunately there is no way to set the timeout of a message currently. This has been brought up with the VS Code team several times, and I believe it is on their backlog. Currently using the non-modal option will hide the message after a certain timeout (Around 20 seconds from what I have seen).

Merge request reports