Skip to content

add commenting range for old files in the MR diff

Tomas Vik requested to merge 340-add-commenting-ranges into main

This is the first MR out of two that will introduce commenting ranges to the MR diff view.

Commenting ranges are marks in the editor gutter that indicate where in the document can the user leave comments.

commenting ranges

This MR adds only commenting range to the old version in the diff. I chose the old file as a start because it doesn't require any complex logic. All lines on the old version of the diff can be commented on.

Feature flags

We can't show the commenting ranges till we implement #342 (closed). Otherwise, users would think they can comment on any line.

The commenting ranges feature is hidden behind commenting-ranges feature flag. You can enable it by adding the following config to your settings.json VS Code settings:

{
  "gitlab.featureFlags": ["commenting-ranges"]
}

Related to #340 (closed)

Edited by Tomas Vik

Merge request reports