Skip to content

chore: improve log output when quitting watch script

Elwyn Bensonrequested to merge
watch-script-nicer-logs-on-exit into main

Description

In chore: ensure child watchers always stop (!2086 - merged) the watch script was adjusted to more reliably run abortController.abort() for child proccesses. While this ensures we don't get dangling background proccesses, the console output when quitting the watcher is not very nice - a raw error object is logged.

Click to expand

image

This MR catches this raw error, and more intentionally logs shortMessage (from execa) instead, which results in tidier output:

image

Related Issues

Resolves #1665 (closed)

How has this been tested?

Start watcher, stop watcher. Smoke test of other scripts.

Screenshots (if appropriate)

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes
Edited by Elwyn Benson

Merge request reports