Skip to content

refactor: remove unused scroll logic

Elwyn Bensonrequested to merge
duo-chat-scroll-cleanup into main

Description

Small change to remove the custom scrollToBottom logic form with the webview App.vue.

This equivalent scrolling behaviour is now implemented directly into the gitlab/ui GlDuoChat component, so is no longer required here.

Related Issues

Resolves #1556 (closed)

How has this been tested?

Open Duo Chat, submit prompt which results in an answer long enough to cause scrolling:

  • ensure chat remains correctly scrolled to the bottom a the answer streams in
  • ensure closing chat panel and re-opening results in being scrolled to the bottom
  • ensure user scrolling up to read a previous message is not being force scrolled to bottom during streaming
  • ensure submitting a new prompt does scroll the user to the bottom

Screenshots (if appropriate)

no visual changes

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes

Merge request reports