Skip to content

chore: don't allow public modifier for public methods

Tomas Vik (OOO back on 2026-01-05)requested to merge
tv/2024-09/no-public-modifier into main

Description

All class methods are public by default https://www.typescriptlang.org/docs/handbook/classes.html#public-by-default

The convention in LS and VS Code Extension is to not use the public modifier for public methods.

LS MR gitlab-org/editor-extensions/gitlab-lsp!768 (merged)

Once the two MRs are merged, I add the config to https://gitlab.com/gitlab-org/frontend/eslint-plugin/-/blob/main/lib/configs/typescript.js?ref_type=heads

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes

Merge request reports