Skip to content

feat(mr review): display whether discussion is resolved or not

Tomas Vik requested to merge 317-resolve-discussion into main

This is the first out of two MR's to implement resolving diff discussions.

It fetches resolved and resolvable flags for each discussion and shows a checkorcross` button representing the action to resolve or unresolve discussion.

resolved unresolved
shows a button to unresolve shows a button to resolve
Extension_Development_Host_-_test_js___3____test-project Extension_Development_Host_-_test_js___3____test-project

The buttons don't trigger any action. That's going to be implemented in the next MR.

How to review

This MR can be easier reviewed as two distinct commits.

Action vs. State

Screenshot_2021-03-02_at_21.03.52

I admit that the showing as an indication of resolved MR is a bit tricky, but we do it so the button represents the action of unresolving. At least there is a hover message explaining the action 🤷 I wasn't able to come up with a better solution. All available icons can be found here: https://microsoft.github.io/vscode-codicons/dist/codicon.html

Related to #317 (closed)

Edited by Tomas Vik

Merge request reports