Skip to content

fix: duo chat feedback form not sending text feedback

Description

This MR fixes Duo Feedback from VS Code is missing text field (gitlab#474473 - closed), we added and renamed a feedback field in the chat component but the change has not been retrofitted into the VS Code Extension. This MR fixes that.

Related Issues

Resolves gitlab#474473 (closed)

How has this been tested?

  1. Run snowplow micro locally

    podman run --name snowplow-micro --rm -e MICRO_IGLU_REGISTRY_URL="https://gitlab-org.gitlab.io/iglu" -p 127.0.0.1:9091:9090 snowplow/snowplow-micro:latest
  2. Provide the trackingUrl for the local Snowplow collector in the VS Code Extension settiongs.json config

    "gitlab.trackingUrl": "http://localhost:9091",
  3. apply this patch

    diff --git a/src/common/snowplow/snowplow_options.ts b/src/common/snowplow/snowplow_options.ts
    index c0b43b9c..66842cca 100644
    --- a/src/common/snowplow/snowplow_options.ts
    +++ b/src/common/snowplow/snowplow_options.ts
    @@ -10,7 +10,7 @@ export type SnowplowOptions = {
     
     export const snowplowBaseOptions: Omit<SnowplowOptions, 'enabled'> = {
       appId: 'gitlab_ide_extension',
    -  endpoint: 'https://snowplow.trx.gitlab.net',
    +  endpoint: 'http://localhost:9091',
       timeInterval: 5000,
       maxItems: 10,
     };
  4. reset the snowplow micro

    curl -s "http://127.0.0.1:9091/micro/reset"
  5. Trigger a chat

  6. use the feedback form

    • fill in the form
    • image
  7. see the extra context in the snowplow micro:

    > curl -s "http://127.0.0.1:9091/micro/good" | jq '.[].event.contexts.data[0].data.extra'
    {
        "improveWhat": "test improve",
        "didWhat": "test do"
    }

I also tested this in JetBrains to make sure that the tracked event is the same

  1. I followed this setup https://gitlab.com/gitlab-org/editor-extensions/gitlab-jetbrains-plugin/-/blob/main/docs/dev/development_environment_setup.md?ref_type=heads#use-snowplow-micro but in the launch config changed the port to 9091
  2. I started the plugin
  3. I submitted the feedback
  4. I checked that the test result is the same as the one above for VS Code Extension

Screenshots (if appropriate)

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes
Edited by Tomas Vik (OOO back on 2026-01-05)

Merge request reports

Loading