Skip to content

fix: Scope duo workflow docker values to all settings

Frédéric Capletterequested to merge
fc-change-docker-default-values into main

Description

It seems that gitlab.duoWorkflow.? was the wrong namespace to the settings because passing any value to this value in either the user settings or to the .vscode settings were not picked up. Dropping this namespace made it so that VsCode could pick up this setting in any cascading settings with its normal priority.

Related Issues

no issues.

How has this been tested?

With this change, adding "gitlab.duoWorkflow.dockerSocket": "/Users/fred/.colima/run/docker.sock" to user settings is picked up by duo workflow docker executor. Without this change, that setting is never used and cannot be updated.

What CHANGELOG entry will this MR create?

  • fix: Bug fix fixes - a user-facing issue in production - included in changelog
  • feature: New feature - a user-facing change which adds functionality - included in changelog
  • BREAKING CHANGE: (fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog
  • None - other non-user-facing changes

Merge request reports