chore: abort extension host given type errors
Description
chore: abort extension host given type errors
Before this commit, if you launch "Run Extension" when there are type
errors in the project, the extension host would start, but the extension
won't be loaded because the watch:desktop script exited due to the
failure.
This is confusing, because it requires digging into the logs to see what happened.
Now, that failure is caught and presented directly, and the extension host is not started.
It could be useful to ignore type errors in such cases while developing the extension, but for now this at least clarifies why the extension isn't loaded.
Related Issues
Related to #1482 (closed)
How has this been tested?
- Introduce a type error (e.g., something that disagress with the type of an import from
@gitlab-org/gitlab-lsp. - Run the extension (F5)
- Note that the extension development host fails to start, with a modal prompt.
Screenshots (if appropriate)
What CHANGELOG entry will this MR create?
-
fix:Bug fix fixes - a user-facing issue in production - included in changelog -
feature:New feature - a user-facing change which adds functionality - included in changelog -
BREAKING CHANGE:(fix or feature that would cause existing functionality to change) - should bump major version, mentioned in the changelog -
None - other non-user-facing changes
Edited by Mark Florian