fix(mr review): don't query position for webview discussions (!160) · Merge requests · GitLab.org / gitlab-vscode-extension

Tomas Vik (OOO back on 2024-11-19) requested to merge 266-work-around-500-issues-for-discussions into main Jan 15, 2021

This limits the blast radius of the existing GitLab issue gitlab#298827 (closed).

For certain MRs (seems to be a subset of MRs that are coming from forks of the project), asking for discussions with positions fails. The GraphQL endpoint returns 500.

gitlab#298827 (closed) is going to affect the MR review diff comments (#266 (closed)) no matter what but this MR limits the blast radius and makes sure that showing comments in the webview (where the position is not needed) still works.

Related to #266 (closed)

fix(mr review): don't query position for webview discussions

Merge request reports