Skip to content

fix: avatars uploaded to GitLab don't show correctly

Tomas Vik (OOO back on 2024-11-19) requested to merge 266-fix-gitlab-uploaded-avatars into main

The existing logic assumed that avatars are always in full URL format (e.g. https://secure.gravatar.com/avatar/6042a9152ada74d9fb6a0cdce895337e?s=80&d=identicon) but that's not true for all avatars. Sometimes the URL is relative (e.g. /uploads/-/system/user/avatar/2398164/avatar.png) and then the avatar image wasn't displayed correctly.

There was also a recently introduced issue when during GrapQL migration we assumed that the image URL is always in user.avatarUrl but there are still some places using the REST response with user.avatar_url. The fix is to check both properties.

This is a pre-existing issue but it's more pronounced with delivering #266 (closed).

before after
feat_mr_review___sho______gitlab-vscode-extension Extension_Development_Host_-_feat_mr_review___sho______gitlab-vscode-extension-TEST
feat_mr_review___sho______gitlab-vscode-extension Extension_Development_Host_-_feat_mr_review___sho______gitlab-vscode-extension-TEST
Extension_Development_Host_-_mr_item_model_ts___158____gitlab-vscode-extension-TEST Extension_Development_Host_-_mr_item_model_ts___158____gitlab-vscode-extension-TEST

Related to #266 (closed)

Merge request reports