fix: FeedbackForm snowplow event missing "environment"
Description
This change introduces the environment
variable into the standard_context
event that is sent on feedback form submissions. Without the environment
variable, which is required, the event fails to send via snowplow and as a result, the metrics are not captured.
This MR also reformats the current telemetry event to be the correct format. The event previously included source
in the extra
section of the telemetry event. The format now resembles what is outlined in the schema.
Related Issues
Resolves part of DuoChat Feedback form not working in VsCode Ext... (gitlab#444328 - closed).
How has this been tested?
This has been tested using snowplow micro to intercept the Feedback Form telemetry events that are being sent from Duo Chat.
Screenshots (if appropriate)
"contexts": {
"schema": "iglu:com.snowplowanalytics.snowplow/contexts/jsonschema/1-0-0",
"data": [
{
"schema": "iglu:com.gitlab/gitlab_standard/jsonschema/1-0-9",
"data": {
"source": "gitlab-vscode",
"extra": {
"extended_feedback": ""
},
"environment": "production"
}
}
]
},
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to change) -
Documentation -
Chore (Related to CI or Packaging to platforms) -
Test gap
Edited by Dylan Bernardi