Skip to content

feat: Add fallback text if CI status does not have illustration

Lennard Sprong requested to merge gitlab-community/gitlab-vscode-extension:X_Sheep/pending-job-fallback into main

Description

In the event of a failed pipeline without a job trace, there was no proper status indicator when clicking the Job item in the sidebar. One such case is when a job times out while in the Pending state, and transitions to the Failed state.

This MR adds a fallback illustration and title when there is no specific illustration available. This is copied from https://gitlab.com/gitlab-community/gitlab/-/blob/beb452d73a7ed6b69228a665a6b28b87e99990f1/lib/gitlab/ci/status/build/common.rb

How has this been tested?

This can be tested with the nonexistant-tag branch in the project https://gitlab.com/X_Sheep/dotnet-test-ci

Screenshots (if appropriate)

Before After
Screenshot_2024-03-07_at_15.22.08 Screenshot_2024-03-07_at_15.21.28

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap

Merge request reports