Skip to content

fix(security_scanning): Hide reports for GitLab Community Edition

Lennard Sprong requested to merge gitlab-community/gitlab-vscode-extension:X_Sheep/security_enterprise_version into main

Description

The point is to avoid contacting the GitLab API for Security Reports, when the API will return a 4xx error. This change does not make any assumptions about the user having the correct permission to use Security Reports.

The Version Check has been updated to read the enterprise field, which is present in versions above 15.6. There is no regression for older GitLab versions, since Security Reports themselves need version 16.1.

Related Issues

Resolves #1000 (closed), #1133 (closed), #1254 (closed)

How has this been tested?

Connecting to GitLab.com should show either a Security Report or the text "No security scans found" in the tree view.

Connecting to a self-hosted GitLab Free or GitLab Premium should hide the security scans tree item, and show the other tree items (issue, merge request, pipeline).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Lennard Sprong

Merge request reports