Skip to content

feat: add multiple filters for issues

Xavier Bruni requested to merge Xavier59/gitlab-vscode-extension:add-new-filters-for-issues into main

Description

Add multiple filters for issues / MR that are referenced in the documentation: https://docs.gitlab.com/ee/api/merge_requests.html
The changes are only for API, I did not add the filters to UI search string.

I tried not to make any breaking change so for every parameter that can be either an id or a username, I am checking the type. If it's a number it's assumed to be an id, if it's a string it'as assumed to be a username. This avoid the confusion of having author and author_id and avoid requiring changing e.g author to author_username and making a breaking change.

I made change to the createQueryString to have different behaviour for building query for API and UI.

Related Issues

<!--- This project only accepts merge requests related to open issues
If suggesting a new feature or change, please discuss it in an issue first
If fixing a bug, there should be an issue describing it with steps to reproduce -->

Unfortunately it was not clear to me (even though I read CONTRIBUTING.md) it was mandatory to open an issue first. I'm learning it now.

How has this been tested?

Unit test pass.
I couldn't run integration test, I'm guessing test.gitlab.com is private to Gitlab Org and requires VPN ?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap

Cheers

Merge request reports