Skip to content

fix: show comments on MR diff (and remove decorations)

Tomas Vik requested to merge tv/2024-02-08/fix-broken-comments into main

Description

This MR fixes a production issue when we don't show comments in MR review.

This MR partially reverts 8e300e54, You can use it during review to verify that this MR doesn't introduce any new code

The issue was caused by partial change to the review file URIs. When we show diff we use the reviewUri to tell VS Code what files are we diffing.

We changed how we generate this URI when we create it.

VS Code maps comments to files based on URIs and we didn't change the way we generate URIs for comments. This caused the bug because VS Code couldn't map comments to diff files.

This MR removes the new change attribute from URI because its not trivial to add it to the comment URI, that's because the GqlTextDiffDiscussion comes from different API call than the RestDiffFile and it doesn't have the boolean flags to easily deduce what is the change type.

Related Issues

Resolves #1243 (closed)

How has this been tested?

Followed the #1243 (closed)

Screenshots (if appropriate)

before after
Screenshot_2024-02-08_at_11.04.44 Screenshot_2024-02-08_at_11.03.24

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Olena Horal-Koretska

Merge request reports