Skip to content

Draft: fix: handle sticky loading icon for stream cancellation

Tristan Read requested to merge tr-fix-sticky-status-icon-for-streaming into main

Description

Deal with sticky loading icon issues that can occur during streaming.

Works by setting loading to false at the end of every piece of a stream, combined with a deactivation delay.

Without the delay, the loading icon would flicker off and on again between the request for each chunk of the stream to the language server.

Doesn't fix the root cause - that the escape button is unbound from the cancellation token for a given in-flight suggestion, between each chunk of a stream. This means there is still some funky behavior. But the persistent loading icon will be fixed by this change.

See #1190 (comment 1761447551) for a deeper explanation.

Related Issues

#1190 (closed)

How has this been tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Tristan Read

Merge request reports