Skip to content

fix: Fix language server browser build path

Enrique Alcántara requested to merge fix-language-server-browser-build into main

Description

It fixes the path to the language-server main bundle for the browser build of the extension. Rather than pointing to main.js , the Web Worker should load the main-bundle.js file that is processed by esbuild to make it compatible with web browser environments.

This Merge Request also fixes the extension build script to only copy the necessary assets to run the language server.

Related Issues

Resolves #[issue_number]

How has this been tested?

In Desktop

You can test the effects of this change in the VSCode Workflow extension's Desktop build by running the extension in development mode. The language server should continue working as usual.

In the Web IDE

Follow the instructions to run the VSCode Workflow Extension in the Web IDE. The language server should load successfully. You can even check that the language server is working correctly in the Web IDE by generating a Personal Access Token in gitlab.com and replacing the following line:

diff --git a/src/common/language_server/language_client_wrapper.ts b/src/common/language_server/language_client_wrapper.ts
index 45c8ac8c..a9c29928 100644
--- a/src/common/language_server/language_client_wrapper.ts
+++ b/src/common/language_server/language_client_wrapper.ts
@@ -71,7 +71,7 @@ export class LanguageClientWrapper {
}
const settings: IConfig = {
baseUrl: platform.account.instanceUrl,
-      token: platform.account.token,
+      token: platform.account.token || '' // Your PAT goes here,
telemetry: {
actions: [{ action: TRACKING_EVENTS.ACCEPTED }],
},

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Enrique Alcántara

Merge request reports