Skip to content

chore: allow pushing tags

Tomas Vik requested to merge tv/2023-12/allow-tags-in-lint into main

Description

This MR fixes an issue when during release, lefthook doesn't let us push tags and we had to use --no-verify during push.

~/w/g/gitlab-vscode-extension (tv/2023-12/allow-tags-in-lint↑1|✔) ❯❯❯ git push
╭────────────────────────────────────╮
│ 🥊 lefthook v1.5.5  hook: pre-push │
╰────────────────────────────────────╯
┃  lint-commits ❯ 

INFO: CI environment variable not detected.
INFO: Linting in local mode...
⧗   input: 3.93.2
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/blob/main/docs/developer/commits.md

How has this been tested?

  1. checkout the branch
  2. create a new tag with npm version patch
  3. delete the tag (to keep your repo clean) git tag -d v3.93.2
  4. checkout test branch git checkout -b lefthook-tag-test
  5. push and see it succeed git push

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Tomas Vik

Merge request reports