Skip to content

refactor: introduce LanguageClientWrapper and first LS tests

Tomas Vik (OOO back on 2024-06-18) requested to merge tv/2023-11/ls-connects-to-state-mngmt into main

Description

This MR refactors the initialization of the language client into a class. This allows us to unit test the logic.

This MR also removed the POC implementation of state management in preparation for using the CodeSuggestionsStateManager.

It might be easier to follow the changes commit-by-commit but this time it's not required.

Related Issues

Part of LS: state management (enabled, disabled, unsupp... (#1052 - closed)

How has this been tested?

  1. Turn on the language server feature flag
  2. Test that the suggestions still work
    • image
  3. Put a breakpoint here and verify that we send the notification when you accept code suggestion

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap
Edited by Tomas Vik (OOO back on 2024-06-18)

Merge request reports