Skip to content

fix: do not throw when remote URL is unexpected

Paul Slaughter requested to merge 1079-fix-url-parse into main

Description

This MR fixes an issue where parsing the GitLab project URL from the git remotes could blow up. This happened whenever a single remote had an unexpected URL.

Related Issues

Resolves #1079 (closed)

How has this been tested?

  1. Update a git repo with multiple remotes pointing to different repos on gitlab.com
  2. Add a remote with a relative file path git remote add local-fs ../another-repo
  3. Start VSCode extension and hit "Refresh" button in GitLab Workflow Extension tab.

Screenshots (if appropriate):

Before After
Screenshot_2023-11-09_at_1.40.29_PM Screenshot_2023-11-09_at_1.38.42_PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)
  • Test gap

Related to #1079 (closed)

Edited by Paul Slaughter

Merge request reports