Remove singleton instantiation from the Snowplow class
The following discussion from !1083 (merged) should be addressed:
-
@viktomas started a discussion: (+1 comment) (non-blocking):
Maybe we could come up with a better name, something likecreateSnowplowInstance
orcreateTelemetry
. ThesetupTelemetry
is a bit misleading to me, I'd expect a side-effect, but we return the provisionedSnowplow
instance.
(non-blocking): Oh I see now that it actually creates a side-effect. In that case it would be great to name the
Snowplow
static method something likeconfigure()
rather than getInstance(). And maybe we could move most of the logic from here into thatconfigure()
method and this file would be redundant. WDYT?