Skip to content

Commits on Source 13

  • Paul Gascou-Vaillancourt's avatar
    refactor: migrate margin and padding includes to Tailwind · 23dd910b
    Paul Gascou-Vaillancourt authored
    Migrates all `@include`d margin and padding mixins to Tailwind's
    `@apply`.
    Those have the exact same names with our Tailwind preset, so the
    migration is as easy as replacing `@include` with `@apply`.
    
    Those occurrences were found and replaced using the following Regex:
    
    ```
    @include gl-([pm])([xytrbl]?)-(\d+)
    ```
    23dd910b
  • Mark Florian's avatar
    chore: Fix GlSorting story in production build · 26db94ec
    Mark Florian authored
    Before, the GlSorting story wasn't rendering in production. Bizarrely,
    the story literally rendered the HTML `<gl-sorting ... ></gl-sorting>`,
    as if Vue is treating it as a custom element. Meanwhile, it rendered
    correctly in the development build.
    
    For reasons that aren't clear, changing how the story is defined fixes
    this.
    
    Addresses #2780.
    26db94ec
  • Lukas Eipert's avatar
    chore: make tailwind less of a headwind · c941bc8a
    Lukas Eipert authored
    Hi Mark! Thank you for nerd-sniping me into this one. This was a wild
    ride of trying to debug what's going on, especially considering the fact
    that it triggered webpack PTSD with relation to CSS imports and such.
    
    So suddenly storybook takes minutes to start instead of seconds.
    It must be something like this performance regression from storybook@7,
    where upgrading to storybook 8 will really help
    https://github.com/storybookjs/storybook/issues/26517. Only logical
    conclusion, let's try to upgrade to storybook@8 which we cannot really
    do because they dropped support for Vue@2 like any sane project would.
    
    But hey, we have an environment level flag, to use Vue@3. So why not
    upgrade partially, and try the Vue@3 version. 60 minutes into upgrading
    storybook and reading their deprecations and whatnot, boom. Build fails.
    But before failing, it just takes 3 minutes start.
    
    Okay, at this point we are in shambles and just suspect that it might be
    webpacks fault. How could it not be? By the way, why are webpack dev
    Tobias Koppers and rollup dev Lukas Taegert-Atkinson both German? Do
    Germans have a natural proclivity to immerse themselves in build tooling
    for the blessed JS ecosystem? Is this the reason I am here doing this
    instead of adding fields to GraphQL entities?
    
    If even the Germans and the predisposition to satisfy their need for
    self-loathing and masochism through the remedy that is build tools is
    not helping, let's go French, at least by name, and our fast salvation
    will be vite. I mean, swapping out webpack, SWC and esbuild for just
    vite and esbuild must solve this, right?
    
    After getting it to work, storybook starts in just 10 seconds. Sweet
    victory at last after two hours in. Let's whip up storybook in the
    browser. Blank pages for three minutes. Back the drawing board.
    
    In this moment it should have clicked because it took some CSS assets
    for three minutes to load. But instead of looking into what we changed
    recently with regards to CSS, I revert back to webpack and start looking
    into the CSS tool chain we have set up for webpack. Faint memories and
    PTSD of OOM issues with relationship to sass-loader and css-loader and
    mini-css-extract-plugin and cache-loader start to re-emerge. After
    trying at least 10 permutations of loaders, disabling source maps,
    moving to sass-embedded, the problematic POS (piece of software) is
    finally cornered: it must be tailwind.
    
    But how? Tailwind performance is not a problem in the GitLab project
    which is much bigger, _why_ would it be so problematic in a much smaller
    project. After some assumptions about webpacks importing logic, trying
    to run tailwind directly in the project takes minutes. But why? We scan
    the gitlab-ui source in the GitLab project as well.
    
    Because we scan everything in the src folder. All of bootstrap-vue, it's
    node_modules, all the specs files, all the story files.
    
    What a ride. Three hours I am never going to get back. Apart from that
    no moral to this story, just a Grimm tale which I won't tell my kids.
    c941bc8a
  • Lukas Eipert's avatar
    chore: re-add stories to tailwind · a1dff063
    Lukas Eipert authored
    Given that this for storybook mainly, we need to scan the stories as
    well.
    a1dff063
  • Paul Gascou-Vaillancourt's avatar
    Merge branch 'fix-sorting-story' into 'main' · fbcd37f8
    Paul Gascou-Vaillancourt authored
    chore: Fix GlSorting story in production build
    
    Closes #2780
    
    See merge request !4601
    
    
    
    Merged-by: default avatarPaul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
    Approved-by: default avatarPaul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
    Co-authored-by: Mark Florian's avatarMark Florian <mflorian@gitlab.com>
    fbcd37f8
  • Mark Florian's avatar
    Merge branch 'wat' into 'main' · 99ff8d37
    Mark Florian authored
    chore: make tailwind less of a headwind
    
    See merge request !4602
    
    
    
    Merged-by: Mark Florian's avatarMark Florian <mflorian@gitlab.com>
    Approved-by: Mark Florian's avatarMark Florian <mflorian@gitlab.com>
    Approved-by: default avatarPaul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
    Reviewed-by: Mark Florian's avatarMark Florian <mflorian@gitlab.com>
    Co-authored-by: default avatarLukas Eipert <leipert@gitlab.com>
    99ff8d37
  • Paul Gascou-Vaillancourt's avatar
    chore: compile typescale styles with PostCSS · 6eef454c
    Paul Gascou-Vaillancourt authored
    Ensures that the `@apply` directive is properly compiled.
    6eef454c
  • Savas Vedova's avatar
    Merge branch 'include-margin-padding-to-tailwind-apply' into 'main' · 4dd14dce
    Savas Vedova authored
    refactor: migrate margin and padding includes to Tailwind
    
    See merge request !4598
    
    
    
    Merged-by: Savas Vedova's avatarSavas Vedova <svedova@gitlab.com>
    Approved-by: Savas Vedova's avatarSavas Vedova <svedova@gitlab.com>
    Approved-by: default avatarLukas Eipert <leipert@gitlab.com>
    Co-authored-by: default avatarPaul Gascou-Vaillancourt <paul.gascvail@gmail.com>
    4dd14dce
  • Paul Gascou-Vaillancourt's avatar
    chore: let the Tailwind migration script migrate SCSS · 1fccf53b
    Paul Gascou-Vaillancourt authored
    This updates the Tailwind CSS migration script so that it migrates utils
    within SCSS files and converts `@include` directives to `@apply`.
    1fccf53b
  • Vanessa Otto's avatar
    feat: Remove unused BootstrapVue components · cdd4a17b
    Vanessa Otto authored
    Remove vendored unused BootstrapVue components and their references
    
    chore: Remove BSkeletonImg
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BAspect
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BAvatar
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BButtonToolbar
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BFormDatepicker
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BCalendar
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BJumbotron
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BListGroup and BListGroupItem
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BMedia, BMediaAside, and BMediaBody
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BNavbarNav
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BNavbarToggle
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BNavForm
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BNavText
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BOverlay
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BPagination and BPaginationNav
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove all BCard components
    
    * BCard
    * BCardBody
    * BCardFooter
    * BCardGroup
    * BCardHeader
    * BCardImg
    * BCardimgLazy
    * BCardSubTitle
    * BCardText
    * BCardTitle
    
    chore: Remove BSidebar
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BRow
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove all BSkeleton components
    
    * BSkeleton
    * BSkeletonIcon
    * BSkeletonTable
    * BSkeletonWrapper
    
    chore: Remove BSpinner
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BImg and BImgLazy
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BContainer
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BEmbed
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove non existing components from d.ts file
    
    chore: Remove component specific loaders
    
    chore: Remove BFormDatalist
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BFormFile
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BFormRating
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BFormTags and BFormTag
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BFormTimepicker
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BTime
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove BFormSpinbutton
    
    Remove vendored unused BootstrapVue file and its references
    
    chore: Remove traces of deleted BV components
    
    Remove utility functions, SCSS variables, SCSS styles and files, and
    constants
    cdd4a17b
  • Vanessa Otto's avatar
    Merge branch '2752-remove-unused-components-from-vendored-bootstrap-vue' into 'main' · 555025c2
    Vanessa Otto authored
    Resolve "Remove unused components from vendored bootstrap-vue"
    
    Closes #2752
    
    See merge request !4591
    
    
    
    Merged-by: default avatarVanessa Otto <votto@gitlab.com>
    Approved-by: default avatarLukas Eipert <leipert@gitlab.com>
    Approved-by: default avatarPaul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
    Reviewed-by: default avatarLukas Eipert <leipert@gitlab.com>
    555025c2
  • Lukas Eipert's avatar
    Merge branch 'tw-migration-script-scss' into 'main' · 9c9f6b2d
    Lukas Eipert authored
    chore: let the Tailwind migration script migrate SCSS
    
    See merge request !4584
    
    
    
    Merged-by: default avatarLukas Eipert <leipert@gitlab.com>
    Approved-by: default avatarLukas Eipert <leipert@gitlab.com>
    Reviewed-by: default avatarLukas Eipert <leipert@gitlab.com>
    Co-authored-by: default avatarPaul Gascou-Vaillancourt <paul.gascvail@gmail.com>
    9c9f6b2d
  • semantic-release-bot's avatar
    chore(release): 92.3.0 [skip ci] · 15119ed7
    semantic-release-bot authored
    # [92.3.0](gitlab-org/gitlab-ui@v92.2.0...v92.3.0) (2024-09-12)
    
    ### Features
    
    * Remove unused BootstrapVue components ([cdd4a17b](gitlab-org/gitlab-ui@cdd4a17b))
    15119ed7
Loading