This adds explicit assertions about how the action callback is called on
disclosure items. This will make it clearer how the following commits
change how the callback is called.

BREAKING CHANGE: The `this` of the `GlDisclosureDropdown` action
callback is now `undefined` rather than the item it's attached to. It
now receives the item as a regular argument instead.

This makes it more similar to the `action` event that's emitted by the
component, such that the same function could be used in either way.

This also means that the same callback can be attached to all items,
instead of requiring a unique callback for each item.

This allows for a simpler way of specifying action items. They no longer
need an `action` method. They simply must not have an `href` string.

This means that if all items are actions, you can simply provide their
text, and then add an `action` event listener to the root component,
rather than add an action listener to each item. It is also still
possible to add unique `action` handlers for each item.

BREAKING CHANGE: Action items are now determined by the *lack* of an
href string. An item with an href string is rendered as a link item,
whether or not it has an action callback.

Before this change, if an item had *both* an href and an action, it
would render as a button. Now, it would render as an anchor.

Enrique Alcántara authored Jan 24, 2023 and Paul Gascou-Vaillancourt committed Jan 24, 2023

The vision of implementing a WYSIWYG editor
in GitLab UI never came to fruition, nevertheless,
this scaffold has been living in GitLab UI without
a good reason 😄.

Let’s remove it to avoid unnecessary noise.

chore: Remove rich text editor component

See merge request !3250



Merged-by: Paul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
Approved-by: Paul Gascou-Vaillancourt <pgascouvaillancourt@gitlab.com>
Co-authored-by: Enrique Alcantara <ealcantara@gitlab.com>

feat(GlDisclosureDropdown): Tweak action/link logic

See merge request !3246



Merged-by: Jose Ivan Vargas <jvargas@gitlab.com>
Approved-by: Olena Horal-Koretska <ohoralkoretska@gitlab.com>
Approved-by: Jose Ivan Vargas <jvargas@gitlab.com>
Reviewed-by: Mark Florian <mflorian@gitlab.com>
Reviewed-by: Olena Horal-Koretska <ohoralkoretska@gitlab.com>
Co-authored-by: Mark Florian <mflorian@gitlab.com>

# [54.0.0](v53.3.0...v54.0.0) (2023-01-24)

### Features

* **GlDisclosureDropdown:** Loosen action item type ([bb2b3087](bb2b3087))
* **GlDisclosureDropdown:** Pass item to action ([8ac2cbf8](8ac2cbf8))

### BREAKING CHANGES

* **GlDisclosureDropdown:** Action items are now determined by the *lack* of an
href string. An item with an href string is rendered as a link item,
whether or not it has an action callback.

Before this change, if an item had *both* an href and an action, it
would render as a button. Now, it would render as an anchor.
* **GlDisclosureDropdown:** The `this` of the `GlDisclosureDropdown` action
callback is now `undefined` rather than the item it's attached to. It
now receives the item as a regular argument instead.

This makes it more similar to the `action` event that's emitted by the
component, such that the same function could be used in either way.

This also means that the same callback can be attached to all items,
instead of requiring a unique callback for each item.