Skip to content

fix(deps): upgrade @floating-ui/dom to v1.6.13

Paul Gascou-Vaillancourtrequested to merge
upgrade-floating-ui-1.6.13 into main

What does this MR do?

This upgrades @floating-ui/dom from v1.4.3 to v1.6.13. We had stopped upgrading this package because our Jest tests broke with v1.4.4 due to some of the lib's functions not being mocked out properly anymore. There's some more context around this here: #2442 (comment 1714120400). It appears that @floating-ui/dom@1.6.4 and above fixed this as all our specs are passing now.

There doesn't seem to be any notable change in the library. Smoke-testing this upgrade in GitLab didn't yield any issue. It does look like some long-lasting issue that caused ResizeObsever loop errors might have been fixed. Again, more context can be found in #2442 (closed). While it's not clear how those errors could be reproduced in the product, our Cypress test suite used to be affected by them, and we had to suppress the error message for the e2e tests to pass. After this upgrade, the errors suppressing doesn't seem necessary anymore. As pointed out in #2442 (comment 2467746725), it appears that Floating UI might now be deferring some behaviors after resize events. This can be seen in the following recording:

resize

Note how it takes a couple seconds for the dropdown to be re-aligned with the toggle. As of writing this, this dropdown gets re-aligned instantaneously on GitLab.com which currently uses @floating-ui/dom@1.4.3. UX-wise this feels perfectly fine. Engineering-wise, this might be the reason we are not seeing ResizeObserver issues and the likes anymore.

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2442 (closed)

Edited by Paul Gascou-Vaillancourt

Merge request reports