Skip to content

Resolve "Prevent dropdowns from overflowing the viewport"

What does this MR do?

Adds the isContained state to dropdown when the container width is >= the viewport's to keep it within bounds.

Screenshots or screen recordings

Storybook:

Before After (left align) After (right align)
CleanShot 2025-04-29 at 12.32.18.gif CleanShot 2025-04-29 at 12.30.05.gif CleanShot 2025-04-29 at 12.33.27.gif

In the wild:

Production Production Mobile Integration Branch
CleanShot 2025-05-05 at 11.35.08.gif CleanShot 2025-05-05 at 11.40.03.gif after

With FluidWidth Prop:

Note: decided against adding spacing around the dropdown at small viewports for two reasons:

  1. This is already an edge case where space is at a premium and design is less than ideal throughout the product.
  2. The implementation of spacing is more involved than simply margin: 0 4px. Considering point 1, it isn't worth the time and added complexity right now.

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2212 (closed)

Edited by Mark Florian

Merge request reports

Loading