Skip to content

fix(GlLink): fix passing of attributes to Vue 3 RouterLink

Peter Hegmanrequested to merge
fix-passing-of-attributes-to-vue3-router-link into main

What does this MR do?

Related to !4897 (comment 2407988730)

An integration test helped us notice that HTML attributes (such as aria-current) were not being passed to the RouterLink anchor tag in Vue 3. This MR fixes this bug and adds specs to help verify the logic.

Screenshots or screen recordings

No visual changes

How to test locally

  1. Add aria-current="true" to src/components/base/link/link.stories.js#L31
  2. Run yarn storybook-vue3
  3. Go to link story and inspect the anchor tag. It should have aria-current="true".

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Peter Hegman

Merge request reports