Skip to content

chore: add typography Storybook story

Scott de Jongerequested to merge
sdejonge-typography-story into main

What does this MR do?

gitlab#523033 (closed) identified that there are elements in GitLab still inheriting styles from Bootstrap stylesheets. In this instance <table class="table"> does not provide dark mode colors.

Future work will be to update generic styles for .table, <kbd>, <code> etc. elements by migrating styles from Bootstrap stylesheets into GitLab UI and use design tokens and Tailwind utilities.

Create Storybook story for generally available HTML typography element to demonstrate style inheritance from user agent, and Bootstrap reset and typography stylesheets.

This Storybook story can be used to visually validate migrations from Bootstrap stylesheets to GitLab UI. As well as providing visual regression testing.

Screenshots or screen recordings

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Merge request reports