Skip to content

feat(GlDatepicker): use variant prop on GlIcon for disabled control

Scott de Jongerequested to merge
sdejonge-design-token-migrations into main

What does this MR do?

Some outstanding color usage in GitLab UI is yet to be migrated to use design tokens. This was discovered in Dark mode > Code Review group (&16679 - closed) • Jeremy Elder, James Rushford, with findings in Figma https://www.figma.com/design/k65T9DcEOoIkRtu3br2bMA/Dark-mode-%3E-Code-review?node-id=2007-153&t=A58khI9z3qHbM1iK-4

  • feat(GlLabel): update scoped label title text color to text.color.strong
  • feat(GlDatepicker): use variant prop on GlIcon for disabled control
    • Add disabled prop to GlDatepicker story

Screenshots or screen recordings

Before After
localhost_9001__path__story_base-datepicker--default_args_disabled__true__2_ localhost_9001__path__story_base-datepicker--default
localhost_9001__path__story_base-datepicker--default_args_disabled__true localhost_9001__path__story_base-datepicker--default_args_disabled__true__1_

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Scott de Jonge

Merge request reports