Skip to content

chore: Allow opting out of building tokens

Mark Florianrequested to merge
build-tokens-dx into main

What does this MR do?

chore: Allow opting out of building tokens

Many actions trigger a rebuild of design tokens, e.g., yarn install, yarn test:unit, or even git commit if lefthook is enabled.

Most of the time, these rebuilds are unnecessary, since the design tokens haven't been modified. The result is that each of these actions takes about two seconds longer than needed.

The best long term solution would be to introduce some kind of smarter build system to handle this automatically. For instance, so it only rebuilds the tokens if the token source files have changed since the last build.

For now, this provides an easy way to opt out of building tokens.

Screenshots or screen recordings

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Merge request reports