Skip to content

chore: Fix toast visual test in Vue 3

Mark Florianrequested to merge
fix-toast-vue3 into main

What does this MR do?

chore: Fix toast visual test in Vue 3

It seems that in Vue 2, toasts are automatically removed when the parent component is destroyed. In Vue 3, that appears not to happen, for some reason.

Ideally that underlying problem would be fixed, but in practice, it shouldn't be much of a problem, since toasts auto-hide eventually anyway.

The reason this matters in the visual tests is that we switch stories between taking screenshots, which means that toast(s) from the previous story might still be present. This meant that the getByRole('status') query of the play function was failing, since more than one toast was present sometimes.

Now, we explicitly hide toasts when the stories are destroyed.

CI changes

Before (failing) After (passing)
https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/8854755023#L633 https://gitlab.com/gitlab-org/gitlab-ui/-/jobs/8861991955#L453

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Mark Florian

Merge request reports