Skip to content

feat(GlLink): Remove `BLink` from `GlLink`

Peter Hegmanrequested to merge
3030-remove-blink-from-gllink into main

What does this MR do?

Closes #3030 (closed)

Removes BLink from GlLink as part of the migration away from Bootstrap Vue. This is a breaking change because I have removed the following props:

  • append
  • event
  • exact
  • exact-path
  • exact-path-active-class
  • no-prefetch
  • router-tag
  • router-component-name

I have removed the following Vue router props for two reasons. They are not used in our codebases and they are not supported by Vue Router V4 (for Vue 3) - https://router.vuejs.org/api/interfaces/RouterLinkProps.html#Interface-RouterLinkProps

Screenshots or screen recordings

gitlab-org/gitlab

Vue router works as expected - gitlab!175643 (merged)

Screen_Recording_2025-01-30_at_2.27.27_PM

GitLab Design

GlLink works with Vue router in a Nuxt project - gitlab-org/gitlab-services/design.gitlab.com!4245 (closed)

Screen_Recording_2025-01-30_at_2.22.00_PM

Vue 3 playground

I created a basic Vue 3 project to test GlLink router functionality in Vue 3 - https://gitlab.com/peterhegman/vue-3-playground

Screen_Recording_2025-01-30_at_2.16.04_PM

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Peter Hegman

Merge request reports