ci: split stylelint job and integrate with Code Quality
What does this MR do?
- Add Code Quality-formatted output to the Stylelint job when it is run in CI.
- To achieve this, split Stylelint out from the main
lint
job. (Only one Code Quality report can be provided for each pipeline job.)
The process for integrating Stylelint is now documented (gitlab!174650 (merged)).
This is very similar to the change, recently merged, that configured ESLint to send its output to Code Quality. !4820 (merged)
Related issues
https://gitlab.com/gitlab-com/Product/-/issues/13766, gitlab#385110 (closed)
Screenshots or screen recordings
This MR is self-testing.
The Code Quality widget shows the new findings. These new findings are from Stylelint. For reference, here is the job report artifact: gl-code-quality-report__15_.json
The job also passes:
Integration merge requests
N/A
-
GitLab: mr_url -
CustomersDot: mr_url -
Status Page: mr_url
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidelines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above). -
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Merge request reports
Activity
assigned to @connorgilbert
1 Warning This MR will trigger no release No release
This Merge Request will trigger no release. This means none of the commits warrant a semantic release according to conventional commits rules (e.g. they only update CI config).
To trigger a release, update one or more commit messages.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend @arfedoro
(UTC+1)
@jivanvl
(UTC-6)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****added 1 commit
- 43e436e3 - ci: split stylelint job and integrate with Code Quality
changed milestone to %17.7
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@connorgilbert
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added 1 commit
- ab1753da - Change to different package that supports console output
added 1 commit
- b605b33b - ci: split stylelint job and integrate with Code Quality
added 1 commit
- c7d1d6fc - ci: split stylelint job and integrate with Code Quality
mentioned in merge request !4871 (closed)
mentioned in merge request gitlab!174650 (merged)
added 13 commits
-
c7d1d6fc...1a321b5f - 12 commits from branch
main
- 394fa60b - ci: split stylelint job and integrate with Code Quality
-
c7d1d6fc...1a321b5f - 12 commits from branch
- Resolved by Paul Gascou-Vaillancourt
@arfedoro could I trouble you for a review of this pipeline change? Just choosing based off of Danger's suggestion.
requested review from @arfedoro
requested review from @pgascouvaillancourt and removed review request for @arfedoro
started a merge train
mentioned in commit 54874c47